feat: Implement MSBuild Central Package Management#2706
Open
Meir017 wants to merge 2 commits intotomkerkhove:masterfrom
Open
feat: Implement MSBuild Central Package Management#2706Meir017 wants to merge 2 commits intotomkerkhove:masterfrom
Meir017 wants to merge 2 commits intotomkerkhove:masterfrom
Conversation
- Create Directory.Packages.props with 60+ package versions organized by category - Enable ManagePackageVersionsCentrally property - Remove Version attributes from all PackageReference elements in 18 project files - Standardize Guard.Net to Guard.NET (uppercase) across all projects - Fix Azure.Monitor.Query version inconsistency (standardized to 1.4.0) - Add security package comments explaining explicitly pinned versions Closes tomkerkhove#2705
|
Thank you for your contribution! 🙏 We will review it as soon as possible. |
|
|
Author
|
Looks like I missed the docker files, I'll see what's missing here |
Meir017
changed the title
Author
|
single test failed https://dev.azure.com/tomkerkhove/Promitor/_build/results?buildId=18486&view=ms.vss-test-web.build-test-results-tab&runId=1033513&resultId=100146&paneView=debug @tomkerkhove is this test flaky? is failed on linux and passed on windows. once in a while this test fails https://dev.azure.com/tomkerkhove/Promitor/_test/analytics?definitionId=50&contextType=build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements MSBuild's Central Package Management (CPM) to manage all 60+ NuGet package versions across 18 projects from a single location.
Changes
src/Directory.Packages.propswithManagePackageVersionsCentrallyenabledVersionattributes from allPackageReferenceelements in 18 project filesGuard.NettoGuard.NET(uppercase) across all projectsAzure.Monitor.Queryversion inconsistency (standardized to 1.4.0)Benefits
✅ Single source of truth for package versions
✅ Easier version updates via Renovate
✅ Prevents version conflicts across projects
✅ Simplified maintenance for the solution
✅ Better dependency visibility for contributors
✅ Consistent versions across all 18 projects
Testing
Closes #2705